Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: enlarge the max split of TTL job #57701

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #57700

What changed and how does it work?

The actual splits = min(tableRegionCount, max(64, tikvStoreCount))

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

ttl: enlarge the max split of TTL job for large clusters

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 26, 2024
@lcwangchao lcwangchao requested a review from YangKeao November 26, 2024 04:42
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 26, 2024
@lcwangchao lcwangchao requested a review from bb7133 November 26, 2024 04:42
Copy link

tiprow bot commented Nov 26, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4022%. Comparing base (d02d48a) to head (c28c9d3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57701        +/-   ##
================================================
+ Coverage   72.8318%   73.4022%   +0.5703%     
================================================
  Files          1677       1677                
  Lines        463944     463997        +53     
================================================
+ Hits         337899     340584      +2685     
+ Misses       105169     102659      -2510     
+ Partials      20876      20754       -122     
Flag Coverage Δ
integration 43.6110% <0.0000%> (?)
unit 72.2189% <100.0000%> (-0.0050%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.5202% <ø> (+0.0090%) ⬆️

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 26, 2024
Copy link

ti-chi-bot bot commented Nov 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-26 05:00:43.280677511 +0000 UTC m=+526230.900332033: ☑️ agreed by YangKeao.
  • 2024-11-26 05:32:39.652529497 +0000 UTC m=+528147.272184012: ☑️ agreed by bb7133.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit b11d034 into pingcap:master Nov 26, 2024
22 checks passed
@lcwangchao lcwangchao deleted the ttl_split_increase branch November 26, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increase the task splits of TTL job in large cluster
4 participants