Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Fixed partition interval from DayMinute to just Minute. #57738

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Nov 26, 2024

What problem does this PR solve?

Issue Number: close #57698

Problem Summary:
A typo using ast.TimeUnitDayMinute instead of ast.TimeUnitMinute lead to PARTITION BY INTERVAL by minute did not work

What changed and how does it work?

Fixed the typo

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed issue that would not allow MINUTE for interval partitioning.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2024
Copy link

tiprow bot commented Nov 26, 2024

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5724%. Comparing base (b11d034) to head (957f2d4).
Report is 77 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57738        +/-   ##
================================================
+ Coverage   72.8126%   75.5724%   +2.7598%     
================================================
  Files          1677       1722        +45     
  Lines        463954     479721     +15767     
================================================
+ Hits         337817     362537     +24720     
+ Misses       105277      95179     -10098     
- Partials      20860      22005      +1145     
Flag Coverage Δ
integration 49.2493% <100.0000%> (?)
unit 72.2094% <100.0000%> (-0.0056%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 61.0573% <ø> (+15.5551%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2024
@Defined2014 Defined2014 requested a review from tangenta November 28, 2024 05:17
@Defined2014
Copy link
Contributor

/run check-issue-triage-complete

@Defined2014
Copy link
Contributor

/retest

Copy link

tiprow bot commented Nov 28, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor

/check-issue-triage-complete

Copy link

ti-chi-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
Copy link

ti-chi-bot bot commented Nov 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-28 05:17:54.063950705 +0000 UTC m=+700061.683605221: ☑️ agreed by Defined2014.
  • 2024-11-28 08:00:27.682666483 +0000 UTC m=+709815.302320998: ☑️ agreed by lance6716.

@Defined2014
Copy link
Contributor

/retest

Copy link

tiprow bot commented Nov 28, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit cc59ab0 into pingcap:master Nov 28, 2024
27 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 5, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to create interval partition at minute interval
4 participants