Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix insert gc failed due to slow schema reload #57742

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Nov 26, 2024

What problem does this PR solve?

Issue Number: close #57743

Problem Summary:

What changed and how does it work?

Wait until schema info finished reloading before proceeding to the rest of the restore process,
Added test to first to reproduce the issue and then add the fix to verify the issue has been fixed (TDD)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed loading schema taking long time during restore causing insertGc row and other operations to fail  

Copy link

ti-chi-bot bot commented Nov 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
Copy link

tiprow bot commented Nov 26, 2024

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@Tristan1900 Tristan1900 force-pushed the schema--much-more-than-data branch from 8b47d90 to 94f9230 Compare November 27, 2024 17:29
@Tristan1900 Tristan1900 marked this pull request as ready for review November 27, 2024 17:29
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 27, 2024
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@Tristan1900
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 27, 2024
@Tristan1900 Tristan1900 changed the title br: reproduce insert gc failed due to slow schema reload br: fix insert gc failed due to slow schema reload Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 43.33333% with 34 lines in your changes missing coverage. Please review.

Project coverage is 75.3716%. Comparing base (2b03447) to head (b9d541a).
Report is 128 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57742        +/-   ##
================================================
+ Coverage   72.8732%   75.3716%   +2.4984%     
================================================
  Files          1677       1731        +54     
  Lines        464202     481515     +17313     
================================================
+ Hits         338279     362926     +24647     
+ Misses       105016      96406      -8610     
- Partials      20907      22183      +1276     
Flag Coverage Δ
integration 49.8512% <41.6666%> (?)
unit 72.8531% <1.6666%> (+0.5827%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 61.5786% <55.5555%> (+15.8750%) ⬆️

@Tristan1900
Copy link
Contributor Author

/assign @Leavrth

@Tristan1900
Copy link
Contributor Author

/assign @lance6716

pkg/domain/domain.go Outdated Show resolved Hide resolved
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

})

// make sure schema reload finishes before proceeding
if err = waitUntilSchemaReload(ctx, client); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about put waitUntilSchemaReload after CleanUpKVFiles?

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 29, 2024
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain part lgtm

Copy link

ti-chi-bot bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, lance6716, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 3, 2024
@lance6716
Copy link
Contributor

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot merged commit 8fe0618 into pingcap:master Dec 3, 2024
31 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57907.

@Tristan1900 Tristan1900 deleted the schema--much-more-than-data branch December 3, 2024 04:51
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 6, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #58038.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@BornChanger BornChanger added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Dec 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #58215.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Tristan1900 added a commit to Tristan1900/tidb that referenced this pull request Dec 12, 2024
Tristan1900 added a commit to Tristan1900/tidb that referenced this pull request Dec 12, 2024
Tristan1900 added a commit to Tristan1900/tidb that referenced this pull request Dec 12, 2024
Tristan1900 added a commit to Tristan1900/tidb that referenced this pull request Dec 12, 2024
Tristan1900 added a commit to Tristan1900/tidb that referenced this pull request Dec 12, 2024
Tristan1900 added a commit to Tristan1900/tidb that referenced this pull request Dec 12, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 17, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 17, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #58334.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: wait till info schema loading finished before proceeding to the rest of the PiTR restore
6 participants