-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix insert gc failed due to slow schema reload #57742
br: fix insert gc failed due to slow schema reload #57742
Conversation
Skipping CI for Draft Pull Request. |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8b47d90
to
94f9230
Compare
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57742 +/- ##
================================================
+ Coverage 72.8732% 75.3716% +2.4984%
================================================
Files 1677 1731 +54
Lines 464202 481515 +17313
================================================
+ Hits 338279 362926 +24647
+ Misses 105016 96406 -8610
- Partials 20907 22183 +1276
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/assign @Leavrth |
/assign @lance6716 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
}) | ||
|
||
// make sure schema reload finishes before proceeding | ||
if err = waitUntilSchemaReload(ctx, client); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about put waitUntilSchemaReload
after CleanUpKVFiles
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain part lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, lance6716, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/check-issue-triage-complete |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
close pingcap#57743 (cherry picked from commit 8fe0618)
close pingcap#57743 (cherry picked from commit 8fe0618)
close pingcap#57743 (cherry picked from commit 8fe0618)
close pingcap#57743 (cherry picked from commit 8fe0618)
close pingcap#57743 (cherry picked from commit 8fe0618)
close pingcap#57743 (cherry picked from commit 8fe0618)
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57743
Problem Summary:
What changed and how does it work?
Wait until schema info finished reloading before proceeding to the rest of the restore process,
Added test to first to reproduce the issue and then add the fix to verify the issue has been fixed (TDD)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.