keyspace: support API V2 mock store #57865

ystaticy · 2024-12-02T03:23:18Z

What problem does this PR solve?

Issue Number: ref #57969

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

support keyspace mock store, and add UT case.

Signed-off-by: ystaticy <y_static_y@sina.com>

tiprow · 2024-12-02T03:23:33Z

Hi @ystaticy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-12-02T03:47:53Z

Codecov Report

Attention: Patch coverage is 86.30137% with 10 lines in your changes missing coverage. Please review.

Project coverage is 73.5878%. Comparing base (12b9421) to head (834fc2c).
Report is 1 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57865        +/-   ##
================================================
+ Coverage   73.1719%   73.5878%   +0.4159%     
================================================
  Files          1674       1674                
  Lines        461065     461163        +98     
================================================
+ Hits         337370     339360      +1990     
+ Misses       102942     101042      -1900     
- Partials      20753      20761         +8

Flag	Coverage Δ
integration	`43.2894% <60.2739%> (?)`
unit	`72.2625% <82.1917%> (-0.0404%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`46.0104% <ø> (+0.0330%)`	⬆️

Signed-off-by: ystaticy <y_static_y@sina.com>

ystaticy · 2024-12-03T14:02:12Z

/test check-dev2

tiprow · 2024-12-03T14:02:34Z

@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: ystaticy <y_static_y@sina.com>

djshow832 · 2024-12-04T06:43:45Z

Please fix CI, rest LGTM

Signed-off-by: ystaticy <y_static_y@sina.com>

ystaticy · 2024-12-04T15:57:08Z

/test unit-test

tiprow · 2024-12-04T15:57:31Z

@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: ystaticy <y_static_y@sina.com>

GMHDBJD

LGTM

ti-chi-bot · 2024-12-05T02:38:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [GMHDBJD,djshow832]
~~pkg/tablecodec/OWNERS~~ [GMHDBJD]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-12-05T02:38:26Z

[LGTM Timeline notifier]

Timeline:

2024-12-04 06:42:43.255459793 +0000 UTC m=+1223550.875114309: ☑️ agreed by djshow832.
2024-12-05 02:38:25.558527811 +0000 UTC m=+1295293.178182326: ☑️ agreed by GMHDBJD.

tiprow · 2024-12-05T02:40:05Z

@ystaticy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	`0df18c2`	link	true	`/test fast_test_tiprow`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ystaticy · 2024-12-05T02:43:38Z

/test fast_test_tiprow

ti-chi-bot · 2024-12-05T02:43:41Z

@ystaticy: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-12-05T02:43:59Z

@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-12-05T02:44:02Z

@ti-chi-bot[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

@ystaticy: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ystaticy · 2024-12-05T03:27:53Z

/test unit-test

tiprow · 2024-12-05T03:28:19Z

@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

api v2 mock store

bd9e7eb

Signed-off-by: ystaticy <y_static_y@sina.com>

ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2024

remove empty line

65a7d85

Signed-off-by: ystaticy <y_static_y@sina.com>

ystaticy added 3 commits December 4, 2024 12:48

fix ut

e3bf5cd

Signed-off-by: ystaticy <y_static_y@sina.com>

add comments

d92c99c

Signed-off-by: ystaticy <y_static_y@sina.com>

add comments

5a995e0

Signed-off-by: ystaticy <y_static_y@sina.com>

djshow832 approved these changes Dec 4, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 4, 2024

ti-chi-bot bot removed the do-not-merge/needs-tests-checked label Dec 4, 2024

ystaticy changed the title ~~support API V2 mock store~~ keyspace: support API V2 mock store Dec 4, 2024

ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Dec 4, 2024

fix ci

7073678

Signed-off-by: ystaticy <y_static_y@sina.com>

fix ut

0df18c2

Signed-off-by: ystaticy <y_static_y@sina.com>

GMHDBJD approved these changes Dec 5, 2024

View reviewed changes

ti-chi-bot bot added the approved label Dec 5, 2024

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024

Merge remote-tracking branch 'origin/master' into ystaticy_apiv2_ut

834fc2c

ti-chi-bot bot merged commit a4278e0 into pingcap:master Dec 5, 2024
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

keyspace: support API V2 mock store #57865

keyspace: support API V2 mock store #57865

ystaticy commented Dec 2, 2024 •

edited

Loading

tiprow bot commented Dec 2, 2024

codecov bot commented Dec 2, 2024 •

edited

Loading

ystaticy commented Dec 3, 2024

tiprow bot commented Dec 3, 2024

djshow832 commented Dec 4, 2024

ystaticy commented Dec 4, 2024

tiprow bot commented Dec 4, 2024

GMHDBJD left a comment

ti-chi-bot bot commented Dec 5, 2024

ti-chi-bot bot commented Dec 5, 2024

tiprow bot commented Dec 5, 2024

ystaticy commented Dec 5, 2024

ti-chi-bot bot commented Dec 5, 2024

tiprow bot commented Dec 5, 2024

tiprow bot commented Dec 5, 2024

ystaticy commented Dec 5, 2024

tiprow bot commented Dec 5, 2024

keyspace: support API V2 mock store #57865

keyspace: support API V2 mock store #57865

Conversation

ystaticy commented Dec 2, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Dec 2, 2024

codecov bot commented Dec 2, 2024 • edited Loading

Codecov Report

ystaticy commented Dec 3, 2024

tiprow bot commented Dec 3, 2024

djshow832 commented Dec 4, 2024

ystaticy commented Dec 4, 2024

tiprow bot commented Dec 4, 2024

GMHDBJD left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Dec 5, 2024

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

tiprow bot commented Dec 5, 2024

ystaticy commented Dec 5, 2024

ti-chi-bot bot commented Dec 5, 2024

tiprow bot commented Dec 5, 2024

tiprow bot commented Dec 5, 2024

ystaticy commented Dec 5, 2024

tiprow bot commented Dec 5, 2024

ystaticy commented Dec 2, 2024 •

edited

Loading

codecov bot commented Dec 2, 2024 •

edited

Loading