Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl,test: fix the datarace in TestShrinkScanWorkerTimeout #57883

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Dec 2, 2024

What problem does this PR solve?

Issue Number: close #57876

Problem Summary:

The worker has started before it sets the context. It may cause data race.

What changed and how does it work?

Set the context before start the worker.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
      It only modified tests.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
@YangKeao
Copy link
Member Author

YangKeao commented Dec 2, 2024

/check-issue-triage-complete

Copy link

ti-chi-bot bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
Copy link

ti-chi-bot bot commented Dec 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-02 08:28:42.77446971 +0000 UTC m=+1057110.394124226: ☑️ agreed by hawkingrei.
  • 2024-12-02 08:30:06.762597091 +0000 UTC m=+1057194.382251606: ☑️ agreed by lcwangchao.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4529%. Comparing base (6d74071) to head (2715df2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57883        +/-   ##
================================================
+ Coverage   72.8728%   73.4529%   +0.5801%     
================================================
  Files          1677       1677                
  Lines        464634     464677        +43     
================================================
+ Hits         338592     341319      +2727     
+ Misses       105154     102570      -2584     
+ Partials      20888      20788       -100     
Flag Coverage Δ
integration 43.3818% <ø> (?)
unit 72.2750% <ø> (+0.0006%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7257% <ø> (+0.0090%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 6434ca4 into pingcap:master Dec 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA RACE in the ttl's TestShrinkScanWorkerTimeout
3 participants