Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: specify go patch-level version #57897

Merged
merged 1 commit into from
Dec 2, 2024
Merged

gomod: specify go patch-level version #57897

merged 1 commit into from
Dec 2, 2024

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #57896

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2024
Copy link

tiprow bot commented Dec 2, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716 lance6716 changed the title gomod: specify go patch-level verison gomod: specify go patch-level version Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
@hawkingrei
Copy link
Member

/check-issue-triage-complete

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4922%. Comparing base (b5b8109) to head (1bb7df4).
Report is 5 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57897        +/-   ##
================================================
+ Coverage   72.8570%   73.4922%   +0.6351%     
================================================
  Files          1677       1679         +2     
  Lines        464688     464902       +214     
================================================
+ Hits         338558     341667      +3109     
+ Misses       105221     102460      -2761     
+ Partials      20909      20775       -134     
Flag Coverage Δ
integration 43.5758% <ø> (?)
unit 72.3263% <ø> (+0.0524%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.8315% <ø> (+0.0449%) ⬆️

Copy link

ti-chi-bot bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
Copy link

ti-chi-bot bot commented Dec 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-02 10:37:12.930360164 +0000 UTC m=+1064820.550014678: ☑️ agreed by hawkingrei.
  • 2024-12-02 12:29:36.279717683 +0000 UTC m=+1071563.899372199: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 453428d into master Dec 2, 2024
24 checks passed
@ti-chi-bot ti-chi-bot bot deleted the lance6716-patch-1 branch December 2, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can not run go command in project root
3 participants