-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: do not record historical stats meta if the table is locked (#57636) #57910
statistics: do not record historical stats meta if the table is locked (#57636) #57910
Conversation
Signed-off-by: Rustin170506 <tech@rustin.me>
Signed-off-by: Rustin170506 <tech@rustin.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, Rustin170506 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57910 +/- ##
================================================
Coverage ? 56.8562%
================================================
Files ? 1771
Lines ? 626802
Branches ? 0
================================================
Hits ? 356376
Misses ? 246299
Partials ? 24127
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #57636
What problem does this PR solve?
Issue Number: close #57628
Problem Summary:
What changed and how does it work?
We don't need to record the historical stats meta if the table is locked because all the information is stored in the locked tables.
So in this PR, we skip the record when the tables are locked.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.