Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: sample once parquet file (#56205) #57921

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56205

What problem does this PR solve?

Issue Number: close #56104

Problem Summary:

What changed and how does it work?

From test, before this pr, lightning importing ten files in parquet format needs to takes 4m40s in the preparation stage. After this pr, lightning importing ten files in parquet format needs to takes 1m10s.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 3, 2024
@zeminzhou
Copy link
Contributor

zeminzhou commented Dec 6, 2024

/cherry-pick-invite

1 similar comment
@CbcWestwolf
Copy link
Member

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@CbcWestwolf you're already a collaborator in repo ti-chi-bot/tidb

@fzzf678
Copy link
Contributor

fzzf678 commented Dec 6, 2024

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@fzzf678 you're already a collaborator in repo ti-chi-bot/tidb

@zeminzhou
Copy link
Contributor

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@zeminzhou Please accept the invitation then you can push to the cherry-pick pull requests.
Comment with "/cherry-pick-invite" if the invitation is expired.
https://github.com/ti-chi-bot/tidb/invitations

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2024
Copy link

ti-chi-bot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2024
Copy link

ti-chi-bot bot commented Dec 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-06 07:28:56.072081487 +0000 UTC m=+1399123.691736002: ☑️ agreed by lance6716.
  • 2024-12-06 07:45:30.065969605 +0000 UTC m=+1400117.685624116: ☑️ agreed by D3Hunter.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@bf0766b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #57921   +/-   ##
================================================
  Coverage               ?   72.2634%           
================================================
  Files                  ?       1415           
  Lines                  ?     414017           
  Branches               ?          0           
================================================
  Hits                   ?     299183           
  Misses                 ?      94877           
  Partials               ?      19957           
Flag Coverage Δ
unit 72.2634% <18.5185%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 54.2732% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit e5fd514 into pingcap:release-7.5 Dec 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants