Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning: Skip apply ioworkers when seek(0, io.SeekCurrent) (#57454) #57930

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57454

What problem does this PR solve?

Issue Number: close #57413

Problem Summary:
When importing from cloud storage, high concurrency can lead to bottlenecks in mydump.PooledReader.Seek(0, io.SeekCurrent) due to the application of ioWorkers. Seek(0, io.SeekCurrent) does not cause disk IO operations, applying ioWorkers is unnecessary.

What changed and how does it work?

Skip apply ioworkers when seek(0, io.SeekCurrent)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 3, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 3, 2024
@lance6716
Copy link
Contributor

/retest

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@bf0766b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #57930   +/-   ##
================================================
  Coverage               ?   72.1526%           
================================================
  Files                  ?       1415           
  Lines                  ?     412825           
  Branches               ?          0           
================================================
  Hits                   ?     297864           
  Misses                 ?      94984           
  Partials               ?      19977           
Flag Coverage Δ
unit 72.1526% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4969% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Dec 4, 2024

@xuanyu66: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716, xuanyu66

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 4, 2024
Copy link

ti-chi-bot bot commented Dec 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-03 09:00:03.156943145 +0000 UTC m=+1145390.776597660: ☑️ agreed by lance6716.
  • 2024-12-04 06:06:18.139733754 +0000 UTC m=+1221365.759388269: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot bot merged commit 7723772 into pingcap:release-7.5 Dec 4, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants