dxf: merge loops in Run and RunStep of task executor #57944
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -459,78 +692,10 @@ func TestCheckBalanceSubtask(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestExecutorErrHandling(t *testing.T) { | |||
There was a problem hiding this comment.
some are duplicate with TestExecutorRun, some moved to TestExecutorRun
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57944 +/- ##
================================================
+ Coverage 73.1421% 73.4626% +0.3205%
================================================
Files 1671 1675 +4
Lines 460703 467586 +6883
================================================
+ Hits 336968 343501 +6533
- Misses 102998 103327 +329
- Partials 20737 20758 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@lance6716 3/4 changes are tests |
| } | ||
|
|
||
| func (e *BaseTaskExecutor) cleanStepExecutor() { | ||
| if err2 := e.stepExec.Cleanup(e.ctx); err2 != nil { |
There was a problem hiding this comment.
check e.stepExec and Cleanup is nil? Not sure it will happen
There was a problem hiding this comment.
e.stepExec != nil is checked at caller
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
@D3Hunter: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #57497
Problem Summary:
What changed and how does it work?
modifycan use the latest param, especially task concurrency which need to alloc slots from slot manager, and it might require recreating the task executor, if we want avoid create/init step executor when we need recreate the task executor, we have to handle param modify detection on both loop, so we merge them to avoid handle them twice.HasSubtasksInStateswhich is not needed now, addGetStepto step executorCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.