Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: lite init used wrong value to build table stats ver #58021

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Dec 5, 2024

What problem does this PR solve?

Issue Number: close #58020

Problem Summary:

What changed and how does it work?

Wrong stats version is set for *statistics.Table when we're under lite init.
It was introduced by #57943

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2024
@winoros winoros added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0672%. Comparing base (f0070f5) to head (201a447).
Report is 5 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58021        +/-   ##
================================================
+ Coverage   73.1621%   74.0672%   +0.9050%     
================================================
  Files          1674       1704        +30     
  Lines        461319     471592     +10273     
================================================
+ Hits         337511     349295     +11784     
+ Misses       103052     100831      -2221     
- Partials      20756      21466       +710     
Flag Coverage Δ
integration 46.3158% <0.0000%> (?)
unit 72.5342% <100.0000%> (+0.2337%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 46.0104% <ø> (+0.0691%) ⬆️

Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2024
@Rustin170506
Copy link
Member

Better to add an init stats + auto-analyze case.

Copy link

ti-chi-bot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 6, 2024
Copy link

ti-chi-bot bot commented Dec 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-06 04:05:44.156393899 +0000 UTC m=+1386931.776048415: ☑️ agreed by Rustin170506.
  • 2024-12-06 07:44:06.979462113 +0000 UTC m=+1400034.599116632: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 5de1105 into pingcap:master Dec 6, 2024
25 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58055.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic in execAnalyzeStmt invalid memory address or nil pointer dereference
4 participants