-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statstics: trigger evict by the timer #58027
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58027 +/- ##
================================================
+ Coverage 73.1711% 75.5406% +2.3694%
================================================
Files 1674 1720 +46
Lines 461507 475985 +14478
================================================
+ Hits 337690 359562 +21872
+ Misses 103079 94303 -8776
- Partials 20738 22120 +1382
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
7601790
to
3d3f03e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code is fine to me, but the necessarity is up to @winoros
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, lance6716, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-8.5 |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #58052
Problem Summary:
What changed and how does it work?
Check List
Tests
after it. we can create a cluster with many table. stop the workload and waiting for no update/insert the stats cache. then you change the stats cache capacity. you will see the stats cache and evict more quick.
before:
after:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.