Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statstics: trigger evict by the timer #58027

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 5, 2024

What problem does this PR solve?

Issue Number: close #58052

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

after it. we can create a cluster with many table. stop the workload and waiting for no update/insert the stats cache. then you change the stats cache capacity. you will see the stats cache and evict more quick.

before:

image

after:

image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.5406%. Comparing base (bb9096c) to head (e99bc17).
Report is 22 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58027        +/-   ##
================================================
+ Coverage   73.1711%   75.5406%   +2.3694%     
================================================
  Files          1674       1720        +46     
  Lines        461507     475985     +14478     
================================================
+ Hits         337690     359562     +21872     
+ Misses       103079      94303      -8776     
- Partials      20738      22120      +1382     
Flag Coverage Δ
integration 49.7581% <0.0000%> (?)
unit 72.8897% <87.5000%> (+0.5925%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 62.4515% <ø> (+16.4681%) ⬆️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei changed the title statstics: trigger evict when to get statstics: trigger evict by the timer Dec 6, 2024
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code is fine to me, but the necessarity is up to @winoros

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 9, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 10, 2024
Copy link

ti-chi-bot bot commented Dec 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-09 08:22:24.476936583 +0000 UTC m=+253934.565739125: ☑️ agreed by AilinKid.
  • 2024-12-10 10:19:24.4956607 +0000 UTC m=+347354.584463243: ☑️ agreed by winoros.

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

ti-chi-bot bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, lance6716, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit d3add7c into pingcap:master Dec 11, 2024
26 checks passed
@hawkingrei hawkingrei deleted the trigger_evict branch December 11, 2024 05:00
@hawkingrei
Copy link
Member Author

/cherrypick release-8.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #58268.

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

faster evict in the stats cache
5 participants