Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2450 #58173

Open
wants to merge 1 commit into
base: release-7.5
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55242

What problem does this PR solve?

Issue Number: close #47400

Problem Summary:

What changed and how does it work?

Ensure that the cardinality estimate does not go below 1. As the estimate approaches zero, then all plans are inexpensive which makes it difficult for the optimizer to differentiate the plan choices.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 11, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2024
@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2376 (#55242) Planner: Do not allow cardinality to go below 1 Dec 12, 2024
@terry1purcell
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2024
Copy link

ti-chi-bot bot commented Dec 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-12 09:41:29.420852605 +0000 UTC m=+517879.509655145: ☑️ agreed by hawkingrei.

@hawkingrei hawkingrei self-requested a review December 12, 2024 09:41
@hawkingrei hawkingrei force-pushed the cherry-pick-55242-to-release-7.5 branch from 158e7c7 to d9cd38f Compare December 12, 2024 09:45
@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2376 Dec 12, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2024
@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2376 Planner: Do not allow cardinality to go below 1 Dec 12, 2024
@terry1purcell
Copy link
Contributor

/retest

@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2448 Dec 12, 2024
@hawkingrei
Copy link
Member

/retest

@hawkingrei hawkingrei changed the title Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2448 Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2450 Dec 13, 2024
@hawkingrei hawkingrei force-pushed the cherry-pick-55242-to-release-7.5 branch from e699da8 to 92269bd Compare December 13, 2024 03:11
@hawkingrei
Copy link
Member

@terry1purcell You have test results that are not updated. The deadline is approaching, please process it as soon as possible

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-55242-to-release-7.5 branch from fc316a3 to bf2b5ce Compare December 13, 2024 05:00
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2024
Copy link

ti-chi-bot bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hawkingrei
Once this PR has been reviewed and has the lgtm label, please assign zimulala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed approved cherry-pick-approved Cherry pick PR approved by release team. labels Dec 13, 2024
Copy link

ti-chi-bot bot commented Dec 13, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Dec 19, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test bf2b5ce link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 bf2b5ce link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test bf2b5ce link true /test mysql-test
idc-jenkins-ci-tidb/check_dev bf2b5ce link true /test check-dev
idc-jenkins-ci-tidb/build bf2b5ce link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants