Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2450 #58173

Open
wants to merge 8 commits into
base: release-7.5
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55242

What problem does this PR solve?

Issue Number: close #47400

Problem Summary:

What changed and how does it work?

Ensure that the cardinality estimate does not go below 1. As the estimate approaches zero, then all plans are inexpensive which makes it difficult for the optimizer to differentiate the plan choices.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 11, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2024
@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2376 (#55242) Planner: Do not allow cardinality to go below 1 Dec 12, 2024
@terry1purcell
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2024
@hawkingrei hawkingrei self-requested a review December 12, 2024 09:41
@hawkingrei hawkingrei force-pushed the cherry-pick-55242-to-release-7.5 branch from 158e7c7 to d9cd38f Compare December 12, 2024 09:45
@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2376 Dec 12, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2024
@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2376 Planner: Do not allow cardinality to go below 1 Dec 12, 2024
@terry1purcell
Copy link
Contributor

/retest

@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2448 Dec 12, 2024
@hawkingrei
Copy link
Member

/retest

@hawkingrei hawkingrei changed the title Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2448 Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2450 Dec 13, 2024
@hawkingrei hawkingrei force-pushed the cherry-pick-55242-to-release-7.5 branch from e699da8 to 92269bd Compare December 13, 2024 03:11
@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2450 Planner: Do not allow cardinality to go below 1 Feb 18, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 18, 2025
@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2483 Feb 18, 2025
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

Copy link

ti-chi-bot bot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 21, 2025
Copy link

ti-chi-bot bot commented Feb 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2024-12-12 09:41:29.420852605 +0000 UTC m=+517879.509655145: ☑️ agreed by hawkingrei.
  • 2025-02-21 09:32:10.197675075 +0000 UTC m=+2678.150833340: ☑️ agreed by Rustin170506.

@Rustin170506
Copy link
Member

/retest

@terry1purcell terry1purcell changed the title Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2483 Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2450 Feb 21, 2025
@Rustin170506
Copy link
Member

/retest

@Rustin170506 Rustin170506 changed the title Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2450 Planner: Do not allow cardinality to go below 1 Feb 25, 2025
@Rustin170506 Rustin170506 changed the title Planner: Do not allow cardinality to go below 1 Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2376 Feb 25, 2025
@Rustin170506 Rustin170506 changed the title Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2376 Planner: Do not allow cardinality to go below 1 Feb 25, 2025
@Rustin170506
Copy link
Member

/retest

@Rustin170506
Copy link
Member

The unit test failed:

        	            	Diff:

        	            	--- Expected

        	            	+++ Actual

        	            	@@ -1,3 +1,3 @@

        	            	-[IndexReader_6 0.00 root  index:IndexRangeScan_5]

        	            	-[└─IndexRangeScan_5 0.00 cop[tikv] table:exp_backoff, index:idx(a, b, c, d) range:[1 1 1 3,1 1 1 5], keep order:false]

        	            	+[IndexReader_6 1.00 root  index:IndexRangeScan_5]

        	            	+[└─IndexRangeScan_5 1.00 cop[tikv] table:exp_backoff, index:idx(a, b, c, d) range:[1 1 1 3,1 1 1 5], keep order:false]

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei changed the title Planner: Do not allow cardinality to go below 1 Planner: Do not allow cardinality to go below 1 | tidb-test=pr/2450 Feb 27, 2025
@hawkingrei
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented Feb 27, 2025

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test a7009cd link true /test mysql-test
idc-jenkins-ci-tidb/unit-test a7009cd link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Feb 28, 2025
Copy link

ti-chi-bot bot commented Feb 28, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/cherry-pick-not-approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants