expression: fix the truncate function when the first arg is 0 and second value is too large

[xzhangxian1008]

What problem does this PR solve?

Issue Number: close #57651

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that truncate function returns NaN when the first arg is 0 and second value is too large

[tiprow]

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8371%. Comparing base (68ac9ec) to head (956d799).
Report is 86 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58191        +/-   ##
================================================
+ Coverage   73.1841%   74.8371%   +1.6529%     
================================================
  Files          1675       1716        +41     
  Lines        461917     484738     +22821     
================================================
+ Hits         338050     362764     +24714     
+ Misses       103127     100741      -2386     
- Partials      20740      21233       +493     

Flag	Coverage Δ
integration	46.9467% <100.0000%> (?)
unit	73.5755% <100.0000%> (+1.2607%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	45.9856% <ø> (+0.0248%)	⬆️

[xzhangxian1008]

/cc @yibin87 @guo-shaoge

[xzhangxian1008]

/cc @guo-shaoge

[yibin87]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-12-16 03:08:46.642032667 +0000 UTC m=+839916.730835209: ☑️ agreed by yibin87.
• 2024-12-18 02:49:09.330528814 +0000 UTC m=+1011539.419331354: ☑️ agreed by guo-shaoge.

[tiprow]

@xzhangxian1008: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tidb_parser_test	956d799	link	true	/test tidb_parser_test
fast_test_tiprow	956d799	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[xzhangxian1008]

/hold

[xzhangxian1008]

/unhold

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [XuHuaiyu,guo-shaoge]
• pkg/expression/OWNERS [XuHuaiyu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xzhangxian1008]

/retest

[tiprow]

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xzhangxian1008]

/retest

[tiprow]

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.