-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add logical plan iterator inside a memo starting with a root group. #58557
Conversation
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58557 +/- ##
================================================
+ Coverage 73.1264% 73.5942% +0.4677%
================================================
Files 1676 1677 +1
Lines 463585 465572 +1987
================================================
+ Hits 339003 342634 +3631
+ Misses 103743 101987 -1756
- Partials 20839 20951 +112
Flags with carried forward coverage won't be shown. Click here to find out more.
|
// IteratorLP serves as iterator to get all logical plan inside memo. | ||
type IteratorLP struct { | ||
root *Group | ||
stackInfo []*list.Element |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stack info is only used for debugging? Do we always need to operate it even if not in debugging mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's for iter position record, one element for each group, when return a LP back, next iteration can start with this position rather than start from 0.
[LGTM Timeline notifier]Timeline:
|
13b41dd
to
f0e5068
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@AilinKid: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #51664
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.