Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade pd client to make sure tso client initiate successfully #58752

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Jan 7, 2025

What problem does this PR solve?

Issue Number: close #55248, close #58239

ref tikv/pd#8962

Problem Summary: tso client may initiate failed

What changed and how does it work?

retry it, and if it always fails after retry, it will report an error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the problem of importing data or adding indexes may fail when PD encounter network problems.

Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked labels Jan 7, 2025
@okJiang
Copy link
Member Author

okJiang commented Jan 7, 2025

/cc @lance6716 @YuJuncen

@ti-chi-bot ti-chi-bot bot requested review from lance6716 and YuJuncen January 7, 2025 08:27
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0918%. Comparing base (c199ddf) to head (5e92f2a).
Report is 10 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58752        +/-   ##
================================================
+ Coverage   73.0885%   74.0918%   +1.0033%     
================================================
  Files          1676       1677         +1     
  Lines        463643     472288      +8645     
================================================
+ Hits         338870     349927     +11057     
+ Misses       103924     101047      -2877     
- Partials      20849      21314       +465     
Flag Coverage Δ
integration 43.1122% <ø> (?)
unit 72.4405% <ø> (+0.1542%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7718% <ø> (+0.0388%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
@okJiang
Copy link
Member Author

okJiang commented Jan 7, 2025

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-07 08:54:55.116841445 +0000 UTC m=+257438.405673151: ☑️ agreed by lance6716.
  • 2025-01-07 09:22:12.049900164 +0000 UTC m=+259075.338731868: ☑️ agreed by YuJuncen.

@okJiang
Copy link
Member Author

okJiang commented Jan 7, 2025

/retest

Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2025
@okJiang
Copy link
Member Author

okJiang commented Jan 8, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 510d003 into pingcap:master Jan 8, 2025
24 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #58802.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 8, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 8, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58803.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #58804.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 8, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
breezewish added a commit that referenced this pull request Jan 8, 2025
…long-vector

* commit '510d0037b18f258f505abc6cf13a8128563e9359':
  *: upgrade pd client to make sure tso client initiate successfully (#58752)
  ttl, test: scale TTL workers during the fault tests (#58750)
  planner: improve warning messages for unsupported HASH_JOIN hints (#58646)
  planner: prealloc the slices in the SplitCorColAccessCondFromFilters (#58785)
  ddl: supports non-unique global index (#58678)
  util/stmtsummary: add the network traffic related fields (#58101)
  var: enable `pd_enable_follower_handle_region` as default (#58385)
  statistics: refactor stats meta handling to use DeltaUpdate for multi-table support (#58657)
  parser: move 'model' to 'ast' pkg (#58704)
  statistics: add recover to protect background task (#58739)
  disttask: cancel subtask context if scheduled away (#58615)
  *: don't handle live updates of column size (#58596)
  *: fix a bug for default_authentication_plugin (2) (#58723)
  dupdetect: gRPC cancel should trigger retry (#58542)
  *: fix a bug for default_authentication_plugin (#57391)
  distsql: Fix backoff execution info inaccurate issue (#58707)
@okJiang okJiang deleted the upgrade-pd-client branch January 9, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
5 participants