Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DXF: check the cause of subtaskCtx to decide the subtask state #58893

Merged
merged 8 commits into from
Jan 22, 2025
Merged

DXF: check the cause of subtaskCtx to decide the subtask state #58893

merged 8 commits into from
Jan 22, 2025

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Jan 13, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58827

Problem Summary:

See #58827 (comment)

What changed and how does it work?

  1. check subtaskCtx instead of stepCtx in markSubTaskCanceledOrFailed
  2. remove checkCtx since we introduced subtaskCtx

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.4518%. Comparing base (6cffa2f) to head (23d27ca).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58893        +/-   ##
================================================
+ Coverage   73.0723%   73.4518%   +0.3795%     
================================================
  Files          1684       1684                
  Lines        466350     466843       +493     
================================================
+ Hits         340773     342905      +2132     
+ Misses       104606     102974      -1632     
+ Partials      20971      20964         -7
Flag Coverage Δ
integration 42.7858% <16.6666%> (?)
unit 72.2260% <83.3333%> (-0.0371%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.3318% <ø> (+0.0374%) ⬆️

@CbcWestwolf
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2025
@CbcWestwolf
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2025
@CbcWestwolf
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-22 06:40:54.677224443 +0000 UTC m=+249382.008143847: ☑️ agreed by tangenta.
  • 2025-01-22 09:27:09.469727998 +0000 UTC m=+259356.800647399: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, fzzf678, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CbcWestwolf
Copy link
Member Author

/retest

1 similar comment
@CbcWestwolf
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit fcdbbd4 into pingcap:master Jan 22, 2025
24 checks passed
@CbcWestwolf CbcWestwolf deleted the dxf_subtask_ctx branch January 23, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzzf678 fzzf678 fzzf678 approved these changes

@tangenta tangenta tangenta approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import into failed after injection ddl owner network partition
4 participants
@CbcWestwolf @D3Hunter @tangenta @fzzf678