Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Update client-go and verify all read ts #58934

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Jan 15, 2025

What problem does this PR solve?

Issue Number: ref #57786

Problem Summary:

What changed and how does it work?

Cherry pick #58054

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Strengthen timestamp validation checks.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. cherry-pick-approved Cherry pick PR approved by release team. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Jan 15, 2025
@ekexium ekexium force-pushed the release-7.1-validate-ts branch 2 times, most recently from 3ec6f5d to 43c47c8 Compare January 15, 2025 06:18
@ekexium ekexium force-pushed the release-7.1-validate-ts branch from 43c47c8 to 186b2c1 Compare January 15, 2025 07:04
@ekexium
Copy link
Member Author

ekexium commented Jan 16, 2025

/retest

Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
Copy link
Member Author

ekexium commented Jan 16, 2025

/retest

@ekexium
Copy link
Member Author

ekexium commented Jan 16, 2025

/retest

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@6423868). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #58934   +/-   ##
================================================
  Coverage               ?   73.4730%           
================================================
  Files                  ?       1213           
  Lines                  ?     382129           
  Branches               ?          0           
================================================
  Hits                   ?     280762           
  Misses                 ?      83417           
  Partials               ?      17950           

@ekexium ekexium requested review from cfzjywxk and zyguan January 16, 2025 10:28
@cfzjywxk cfzjywxk requested review from you06 and MyonKeminta January 16, 2025 10:38
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 16, 2025
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2025
@ekexium
Copy link
Member Author

ekexium commented Jan 22, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 22, 2025
Copy link

ti-chi-bot bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MyonKeminta, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 22, 2025
Copy link

ti-chi-bot bot commented Jan 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-16 14:52:17.291273299 +0000 UTC m=+216608.746319447: ☑️ agreed by zyguan.
  • 2025-01-22 09:44:16.922494766 +0000 UTC m=+260384.253414183: ☑️ agreed by MyonKeminta.

@ti-chi-bot ti-chi-bot bot merged commit 927aa59 into pingcap:release-7.1 Jan 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants