Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expr: support from_unixtime pushdown to tikv #58941

Merged
merged 4 commits into from
Jan 24, 2025
Merged

expr: support from_unixtime pushdown to tikv #58941

merged 4 commits into from
Jan 24, 2025

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Jan 15, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58940

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

support from_unixtime pushdown to tikv

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 15, 2025
@wshwsh12
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/needs-tests-checked labels Jan 15, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 15, 2025

Hi @wshwsh12. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2025
@wshwsh12
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4266%. Comparing base (4e1cf8a) to head (c2a8d16).
Report is 39 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58941        +/-   ##
================================================
+ Coverage   73.0706%   73.4266%   +0.3559%     
================================================
  Files          1683       1689         +6     
  Lines        465734     481339     +15605     
================================================
+ Hits         340315     353431     +13116     
- Misses       104494     106226      +1732     
- Partials      20925      21682       +757
Flag Coverage Δ
integration 42.8299% <ø> (?)
unit 72.2397% <ø> (-0.0160%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 44.5705% <ø> (-0.7291%) ⬇️

xzhangxian1008
xzhangxian1008 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 21, 2025
windtalker
windtalker reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test case in TestExprPushDownToTiKV?

zimulala
zimulala approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 23, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-21 06:17:06.729878886 +0000 UTC m=+161554.060798286: ☑️ agreed by xzhangxian1008.
  • 2025-01-23 02:29:59.267833995 +0000 UTC m=+320726.598753399: ☑️ agreed by zimulala.

@wshwsh12 wshwsh12 requested a review from windtalker January 24, 2025 02:26
windtalker
windtalker approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 24, 2025
@ti-chi-bot ti-chi-bot bot merged commit 4636702 into pingcap:master Jan 24, 2025
22 checks passed
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Jan 26, 2025
@wshwsh12 @hawkingrei
expr: support from_unixtime pushdown to tikv (pingcap#58941)
19bb67b 
close pingcap#58940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

@zimulala zimulala zimulala approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support from_unixtime pushdown to tikv
4 participants
@wshwsh12 @windtalker @zimulala @xzhangxian1008