Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: make the logical op's shallow ref generator. #59124

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jan 22, 2025

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

cascades infra will require some operator's clone in XForm action, while sometimes we can only get a shallow copy of an operator according to the ref is a pointer or structure. By XXXshallowRef functionality, we can safely shallow copy a map/slice/or embedded ones before modify them in the new clonedOp.

clonedJoin := *p
clonedJoin._EqualConditionsShallowRef()
// shallow cp it before your use it, otherwise your appending stuff will modify the original slice in other operator.
// since it's shallowed one, once you want to modify them, your should substitute them basic element totally rather
// modify in-place like:
clonedJoin._EqualConditionsShallowRef()[0] = newFunction(xxx)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 22, 2025
Copy link

tiprow bot commented Jan 22, 2025

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 52.75591% with 60 lines in your changes missing coverage. Please review.

Project coverage is 74.4907%. Comparing base (dfc0035) to head (8408799).
Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59124        +/-   ##
================================================
+ Coverage   73.0571%   74.4907%   +1.4336%     
================================================
  Files          1684       1689         +5     
  Lines        466439     477725     +11286     
================================================
+ Hits         340767     355861     +15094     
+ Misses       104729     100469      -4260     
- Partials      20943      21395       +452     
Flag Coverage Δ
integration 44.1552% <0.0000%> (?)
unit 73.3049% <52.7559%> (+1.0590%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.3606% <ø> (+0.0546%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 23, 2025
@AilinKid
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Jan 23, 2025

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 23, 2025
Copy link

ti-chi-bot bot commented Jan 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-23 03:29:18.781738321 +0000 UTC m=+324286.112657722: ☑️ agreed by qw4990.
  • 2025-01-23 04:47:22.432989114 +0000 UTC m=+328969.763908517: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 23, 2025
.
Signed-off-by: AilinKid <314806019@qq.com>
.
Signed-off-by: AilinKid <314806019@qq.com>
.
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid AilinKid force-pushed the add-logical-op-shallow-ref-gen branch from 780c2fc to 8408799 Compare January 23, 2025 07:49
@AilinKid
Copy link
Contributor Author

/test build

Copy link

tiprow bot commented Jan 23, 2025

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AilinKid AilinKid closed this Jan 23, 2025
@AilinKid AilinKid reopened this Jan 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit eab3f4c into pingcap:master Jan 23, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants