-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: make the logical op's shallow ref generator. #59124
planner: make the logical op's shallow ref generator. #59124
Conversation
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59124 +/- ##
================================================
+ Coverage 73.0571% 74.4907% +1.4336%
================================================
Files 1684 1689 +5
Lines 466439 477725 +11286
================================================
+ Hits 340767 355861 +15094
+ Misses 104729 100469 -4260
- Partials 20943 21395 +452
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest-required |
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/ok-to-test |
780c2fc
to
8408799
Compare
/test build |
@AilinKid: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #51664
Problem Summary:
What changed and how does it work?
cascades infra will require some operator's clone in XForm action, while sometimes we can only get a shallow copy of an operator according to the ref is a pointer or structure. By XXXshallowRef functionality, we can safely shallow copy a map/slice/or embedded ones before modify them in the new clonedOp.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.