Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support long varchar #5920

Merged
merged 10 commits into from
Mar 3, 2018
Merged

Conversation

zhexuany
Copy link
Contributor

This PR supports long varchar which is alias of mediumtext.

@zhexuany zhexuany changed the title Fix issue 5918 parser: support long varchar Feb 28, 2018
@jackysp
Copy link
Member

jackysp commented Feb 28, 2018

Please add the issue link in the description.

@coocood
Copy link
Member

coocood commented Feb 28, 2018

LGTM

@shenli
Copy link
Member

shenli commented Feb 28, 2018

/run-all-tests

@zhexuany
Copy link
Contributor Author

This should fix #5918. @shenli PTAL. If everything looks good, it now can be merged.

@shenli
Copy link
Member

shenli commented Feb 28, 2018

LGTM

@shenli
Copy link
Member

shenli commented Feb 28, 2018

@zhexuany If all the tests passed, please add the all-tests-passed label for the PR.

@shenli
Copy link
Member

shenli commented Feb 28, 2018

/run-all-tests

@shenli shenli added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 28, 2018
@shenli
Copy link
Member

shenli commented Mar 1, 2018

@zhexuany Please fix the CI.

@zhexuany
Copy link
Contributor Author

zhexuany commented Mar 1, 2018

Ran unit-test locally, passed. Reran all tests. /run-all-tests

@zhexuany
Copy link
Contributor Author

zhexuany commented Mar 1, 2018

merge master's changes and run all tests: /run-all-tests

@zhexuany
Copy link
Contributor Author

zhexuany commented Mar 1, 2018

@shenli PTAL

@zhexuany
Copy link
Contributor Author

zhexuany commented Mar 1, 2018

/run-all-tests

@iamxy
Copy link
Member

iamxy commented Mar 2, 2018

/run-unit-test

@shenli
Copy link
Member

shenli commented Mar 2, 2018

Could we merge this now?

@zhexuany
Copy link
Contributor Author

zhexuany commented Mar 2, 2018

/run-all-tests

@zhexuany
Copy link
Contributor Author

zhexuany commented Mar 2, 2018

Its ready to merge.

@zhexuany zhexuany added all-tests-passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Mar 2, 2018
@zz-jason zz-jason merged commit 1a812fc into pingcap:master Mar 3, 2018
@zhexuany zhexuany deleted the fix_issue_5918 branch March 3, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants