executor,ast: check password format for 'create user identified by password XXX' #5948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssword XXX' 'create user xxx identified by yyy', yyy can be any text 'create user xxx identified by password yyy', yyy must be a hash string generated by password(), it begin with * and has length 41
jackysp
reviewed
Mar 5, 2018
ast/misc.go
Outdated
| return opt.HashString, true | ||
| } | ||
|
|
||
| func maybePasswordString(str string) bool { |
There was a problem hiding this comment.
So, any suggestion? @jackysp
|
/run-all-tests |
tiancaiamao
force-pushed
the
check-password-format
branch
from
2ce3f9c to
b64c4ac
Compare
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'create user xxx identified by yyy', yyy can be any text
'create user xxx identified by password yyy', yyy must be a hash string generated by
password(), it begin with * and has length 41
@zz-jason @jackysp @winkyao