json, expr: json_search should return NULL when the search path is NULL | tidb-test=pr/2486
#59714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59714 +/- ##
================================================
+ Coverage 72.9458% 73.3664% +0.4206%
================================================
Files 1699 1699
Lines 469236 469281 +45
================================================
+ Hits 342288 344295 +2007
+ Misses 105854 103891 -1963
- Partials 21094 21095 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
YangKeao
changed the title
json_search should return NULL when the search path is NULLjson_search should return NULL when the search path is NULL | tidb-test=pr/2486
|
/retest |
xhebox
approved these changes
Feb 25, 2025
XuHuaiyu
approved these changes
Feb 25, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xhebox, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
|
/retest |
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #59463
Problem Summary:
The
json_searchshould returnNULLwhen the search path isNULL. It's not the same with the situation when the search path is omitted.This issue only affects the vectorized execution. The non-vectorized logic is correct.
What changed and how does it work?
Return
NULLwhen it found the search path isNULL.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.