executor: Improve the aesthetics of code review #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
zz-jason
reviewed
Mar 23, 2018
| @@ -357,8 +357,8 @@ func (s *testSuite) TestGroupConcatAggr(c *C) { | |||
| result = tk.MustQuery("select id, group_concat(name SEPARATOR ',') from test group by id") | |||
| result.Check(testkit.Rows("1 10,20,30", "2 20", "3 200,500")) | |||
|
|
|||
| result = tk.MustQuery("select id, group_concat(name SEPARATOR '%') from test group by id") | |||
| result.Check(testkit.Rows("1 10%20%30", "2 20", "3 200%500")) | |||
| result = tk.MustQuery(`select id, group_concat(name SEPARATOR '%') from test group by id`) | |||
There was a problem hiding this comment.
maybe we should change all the " to ` in other MustQuery function calls ?
There was a problem hiding this comment.
OK, Is MustExec/Exec/... should also be modified？
There was a problem hiding this comment.
Maybe I should amend it so that when we change this issue, we also change the other items of this file?
e.g MustExec,Exec, MustQuery
|
LGTM |
kangxiaoning
added a commit
to kangxiaoning/tidb
that referenced
this pull request
Mar 24, 2018
executor: Improve the aesthetics of code review pingcap#6130
|
/run-all-tests |
zz-jason
added
contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.