Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: remove unused code #6193

Merged
merged 2 commits into from
Mar 30, 2018
Merged

executor: remove unused code #6193

merged 2 commits into from
Mar 30, 2018

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Mar 30, 2018 •
edited
Loading

Remove all the unused code in package "executor". We can rename NextChunk to Next in next PR.

@zz-jason
Copy link
Member Author

/run-all-tests

@zz-jason
Copy link
Member Author

@XuHuaiyu @winoros PTAL

XuHuaiyu
XuHuaiyu reviewed Mar 30, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2018
coocood
coocood approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2018
@zz-jason
Copy link
Member Author

/run-sqllogic-test

@winoros winoros merged commit 9c4cef8 into pingcap:master Mar 30, 2018
@zz-jason zz-jason deleted the dev/executor/removecode branch May 15, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zz-jason @coocood @XuHuaiyu @winoros