column: fix zero value for binary type #6213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zero value for BINARY type should be byte slice with length.
|
/run-all-tests |
|
LGTM |
zz-jason
reviewed
Apr 3, 2018
| } else { | ||
| d.SetString("") | ||
| } | ||
| case mysql.TypeVarString, mysql.TypeVarchar: |
There was a problem hiding this comment.
should we consider TypeVarString ?
There was a problem hiding this comment.
No, VarString is not fixed length type, does not padding to the length.
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero value for BINARY type should be byte slice with length.