kv: merge batch get results to fix insert ignore in a transaction block #6215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackysp |
coocood
reviewed
Apr 3, 2018
kv/txn.go
Outdated
| // BatchGetValues gets values in batch. | ||
| // The values from buffer in transaction and the values from the storage node are merged together. | ||
| func BatchGetValues(txn Transaction, keys []Key) (map[string][]byte, error) { | ||
| bufferValues := make(map[string][]byte, len(keys)) |
There was a problem hiding this comment.
Using a keys slice and a values slice has a lower cost.
|
PTAL @coocood |
|
LGTM |
|
/run-all-tests |
coocood
changed the title
zimulala
reviewed
Apr 4, 2018
| continue | ||
| } | ||
| storageValues[string(key)] = bufferValues[i] | ||
| } |
There was a problem hiding this comment.
Do we need to do CheckVisibility(txn.startTS) ?
There was a problem hiding this comment.
In (s *tikvSnapshot) BatchGet , it is already been checked.
There was a problem hiding this comment.
Ignore it.
We do it in BatchGet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the batch get results with buffer store to fix insert ignore bug when it is in a transaction block.
PTAL @coocood