plan: always clone Expression when set it to plan.
#6263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngaut
changed the title
Expression when set it to plan.Expression when set it to plan.
|
/run-all-tests |
zhexuany
reviewed
Apr 12, 2018
| @@ -133,8 +133,14 @@ func (p *LogicalJoin) PredicatePushDown(predicates []expression.Expression) (ret | |||
| case InnerJoin: | |||
| p.LeftConditions = nil | |||
| p.RightConditions = nil | |||
| p.EqualConditions = equalCond | |||
| p.OtherConditions = otherCond | |||
| p.EqualConditions = make([]*expression.ScalarFunction, 0, len(equalCond)) | |||
There was a problem hiding this comment.
p.EqualConditions = make([]*expression.ScalarFunction, len(equalCond)) ?
We need fulfill expression later anyway.
There was a problem hiding this comment.
Will this change affect too much?
There was a problem hiding this comment.
I think it's ok to use append.
We don't need to think if make full length is applicable, we can safely use append.
There was a problem hiding this comment.
I won't change as much. It is just neat to use the way I proposed.
There was a problem hiding this comment.
And yes. It's perfect fine to use append.
|
LGTM |
|
/run-all-tests |
winoros
added
status/LGT1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current master can be panicked by the test added.
PTAL @XuHuaiyu @zz-jason @lamxTyler
Better be merged after #6260 and #6262