executor: fix index lookup join hang #6267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index lookup join inner worker should keep consuming the task channel and should not return on error, or the task channel maybe full and blocks forever.
coocood
added
priority/P1
|
@zz-jason @shenli @tiancaiamao PTAL |
zz-jason
reviewed
Apr 11, 2018
| @@ -392,9 +392,6 @@ func (iw *innerWorker) run(ctx context.Context, wg *sync.WaitGroup) { | |||
|
|
|||
| err := iw.handleTask(ctx, task) | |||
| task.doneCh <- errors.Trace(err) | |||
| if err != nil { | |||
There was a problem hiding this comment.
we should close iw.taskCh to let outer workers stop running as soon as possible.
There was a problem hiding this comment.
When the caller received the error, it will close the executor, then the context will be canceled, all workers will quit.
|
Without the fix, the test blocks forever. |
winoros
reviewed
Apr 11, 2018
executor/index_lookup_join_test.go
Outdated
| import ( | ||
| . "github.com/pingcap/check" | ||
| "github.com/pingcap/tidb/util/testkit" | ||
| "context" |
|
LGTM |
|
/run-all-tests |
|
/run-all-tests tidb-test=pr/493 |
|
/run-integration-common-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index lookup join inner worker should keep consuming the task channel and should not return on error,
or the task channel maybe full and blocks forever.