Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: change some function names to improve code readability #6270

Merged
merged 7 commits into from
Apr 12, 2018

Conversation

zz-jason
Copy link
Member

No description provided.

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests

@XuHuaiyu XuHuaiyu added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 12, 2018
@tiancaiamao
Copy link
Contributor

Should we merge this kind of changes after 2.0GA? @shenli

@zimulala
Copy link
Contributor

/run-all-tests

@zhexuany zhexuany merged commit ca627fe into pingcap:master Apr 12, 2018
@zz-jason zz-jason deleted the dev/plan/readability branch April 12, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants