Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: update the column's offset when we do modify column #6274

Merged
merged 3 commits into from
Apr 12, 2018
Merged

ddl: update the column's offset when we do modify column #6274

merged 3 commits into from
Apr 12, 2018

Conversation

zimulala
Copy link
Contributor

cherry-pick #6269

@zimulala zimulala added the DDL label Apr 12, 2018
@zimulala
Copy link
Contributor Author

/run-all-tests

winkyao
winkyao reviewed Apr 12, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added cherry-pick status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2018
@zimulala
Copy link
Contributor Author

/run-integration-common-test

jackysp
jackysp approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/497

@zimulala
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/497 tikv=pr/2940

@zimulala zimulala merged commit 28c21c9 into pingcap:master Apr 12, 2018
@zimulala zimulala deleted the modify-col branch April 12, 2018 10:50
@zimulala zimulala mentioned this pull request Apr 17, 2018
Merged
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zimulala @jackysp @winkyao @coocood @you06