Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support insert ignore on duplicate update #6283

Merged
merged 2 commits into from
Apr 13, 2018
Merged

executor: support insert ignore on duplicate update #6283

merged 2 commits into from
Apr 13, 2018

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Apr 13, 2018

It seems TiDB has never supported ignore combine with on duplicate key update together in insert statement.
PTAL @coocood

@coocood coocood added the type/bugfix This PR fixes a bug. label Apr 13, 2018
@coocood
Copy link
Member

coocood commented Apr 13, 2018

LGTM

@coocood coocood added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2018
@coocood
Copy link
Member

coocood commented Apr 13, 2018

@zimulala PTAL

zimulala
zimulala approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

/run-all-tests

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2018
@jackysp jackysp merged commit 3513319 into pingcap:master Apr 13, 2018
@jackysp jackysp deleted the support_insert_ignore_ondup branch May 22, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackysp @coocood @zimulala @ngaut