Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variable: set default hash join concurrency in NewSessionVars #6295

Merged
merged 3 commits into from
Apr 16, 2018
Merged

variable: set default hash join concurrency in NewSessionVars #6295

merged 3 commits into from
Apr 16, 2018

Conversation

zz-jason
Copy link
Member

No description provided.

@winoros
Copy link
Member

winoros commented Apr 16, 2018

We may need to add test in varsutil_test.go

@zz-jason
Copy link
Member Author

/run-all-tests

@zz-jason zz-jason added the type/bugfix This PR fixes a bug. label Apr 16, 2018
@zz-jason
Copy link
Member Author

@winoros @zimulala PTAL

winoros
winoros reviewed Apr 16, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just add things to TestVarsutil?

@zz-jason
Copy link
Member Author

TestVarsutil is more likely to test SetSessionSystemVar and its logic is complex enough ?

XuHuaiyu
XuHuaiyu reviewed Apr 16, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2018
winoros
winoros reviewed Apr 16, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2018
@zz-jason zz-jason merged commit 88a6a0d into pingcap:master Apr 16, 2018
@zz-jason zz-jason deleted the dev/sessionctx/hashjoinconcurrency branch April 16, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zz-jason @winoros @XuHuaiyu