Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #63099

What problem does this PR solve?

Issue Number: ref #61553

Problem Summary:

When I cherry-pick #61622 to master(#61555), the http handler registering part is missed. We can't modify the ingest parameters through http API.

What changed and how does it work?

Register missing http handlers related to ingest param.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
❯ curl http://127.0.0.1:10080/ingest/max-batch-split-ranges
{
 "is_null": false,
 "value": 2048
}% 
❯ curl http://127.0.0.1:10080/ingest/max-batch-split-ranges -X POST -d '{"value": 1}'
{
 "message": "success"
}%                                                                              
❯ curl http://127.0.0.1:10080/ingest/max-batch-split-ranges
{
 "is_null": false,
 "value": 1
}%                                                                         
❯ curl http://127.0.0.1:10080/ingest/max-split-ranges-per-sec -X POST -d '{"value": 123}'
{
 "message": "success"
}%                                                                              
❯ curl http://127.0.0.1:10080/ingest/max-ingest-inflight -X POST -d '{"value": 5}'
{
 "message": "success"
}%                                                                              
❯ curl http://127.0.0.1:10080/ingest/max-ingest-per-sec -X POST -d '{"value": 0.35}'
{
 "message": "success"
}% 
[2025/08/20 17:34:25.600 +08:00] [INFO] [local.go:1232] ["start import engine"] [task-id=3] [task-key=ddl/backfill/120] [subtaskID=3] [step=read-index] [uuid=59619405-c4b5-56d9-8335-6527f473cadd] ["region ranges"=1] [count=1] [size=38] [maxReqInFlight=5] [maxReqPerSec=0.35]
[2025/08/20 17:34:25.600 +08:00] [INFO] [local.go:918] ["import engine ranges"] [task-id=3] [task-key=ddl/backfill/120] [subtaskID=3] [step=read-index] [len(regionSplitKeys)=2] [splitRangesBatch=1] [splitRangePerSec=123]
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Sep 12, 2025
@ti-chi-bot
Copy link
Member Author

@tangenta This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: tangenta <tangenta@126.com>
@tangenta tangenta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 16, 2025
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5@a8777b2). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #63485   +/-   ##
================================================
  Coverage               ?   57.3525%           
================================================
  Files                  ?       1783           
  Lines                  ?     634563           
  Branches               ?          0           
================================================
  Hits                   ?     363938           
  Misses                 ?     246282           
  Partials               ?      24343           
Flag Coverage Δ
integration 37.4804% <88.0000%> (?)
unit 72.8098% <88.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.8329% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tangenta
Copy link
Contributor

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 16, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-16 03:11:34.996481063 +0000 UTC m=+935761.556362550: ☑️ agreed by tangenta.
  • 2025-09-16 03:46:39.305698458 +0000 UTC m=+937865.865579965: ☑️ agreed by D3Hunter.

@tangenta
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 18, 2025
@tangenta
Copy link
Contributor

/retest

@tangenta
Copy link
Contributor

/retest

2 similar comments
@Benjamin2037
Copy link
Collaborator

/retest

@Benjamin2037
Copy link
Collaborator

/retest

@Benjamin2037
Copy link
Collaborator

/retest

@tangenta
Copy link
Contributor

/retest

2 similar comments
@tangenta
Copy link
Contributor

/retest

@tangenta
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1c16548 into pingcap:release-8.5 Sep 23, 2025
18 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-63099-to-release-8.5 branch September 23, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants