tidb-server: move "setupMetrics" to the front of "createStoreAndDomain" #6921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
Review status: 0 of 1 files reviewed, all discussions resolved Comments from Reviewable |
zz-jason
added
type/enhancement
|
We should cherry-pick this to the release-2.0. |
shenli
approved these changes
Jun 27, 2018
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Jun 28, 2018
coocood
pushed a commit
that referenced
this pull request
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Move "setupMetrics" to the front of "createStoreAndDomain".
Make sure that the metric works when we do the operation of
bootstrap.What are the type of the changes (mandatory)?