Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: handle \N as NULL in load data statement #6962

Merged
merged 5 commits into from
Jul 3, 2018

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jul 3, 2018

What have you changed? (mandatory)

Cherry pick #6873 to release 2.0

What are the type of the changes (mandatory)?

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested (mandatory)?

uint test

PTAL @tiancaiamao @zimulala

@jackysp
Copy link
Member Author

jackysp commented Jul 3, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2018
@tiancaiamao
Copy link
Contributor

LGTM

@jackysp
Copy link
Member Author

jackysp commented Jul 3, 2018

@zimulala and @tiancaiamao , thank you for your LGTM. This commit cannot be cherry-picked automatically, so PTAL again.

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 3, 2018
@zz-jason zz-jason merged commit b236944 into pingcap:release-2.0 Jul 3, 2018
@jackysp jackysp deleted the asnull branch August 7, 2018 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants