Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser,ast: parse statement execution time optimizer hints #7012

Merged
merged 4 commits into from
Jul 8, 2018

Conversation

tiancaiamao
Copy link
Contributor

What have you changed? (mandatory)

Parse MAX_EXECUTION_TIME and ignore it.

Before this PR:

mysql> SELECT /*+ MAX_EXECUTION_TIME(1000) */ 1 ;
ERROR 1105 (HY000): line 1 column 38 near " 1" (total length 40)

After this PR:

mysql> SELECT /*+ MAX_EXECUTION_TIME(1000) */ 1 ;
+---+
| 1 |
+---+
| 1 |
+---+
1 row in set (0.00 sec)

What are the type of the changes (mandatory)?

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested (mandatory)?

unit tests

Refer to a related PR or issue link (optional)

Fix #7008

PTAL @lysu @shenli

@shenli
Copy link
Member

shenli commented Jul 8, 2018

LGTM

@lysu
Copy link
Contributor

lysu commented Jul 8, 2018

/run-all-tests

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao merged commit 10151e1 into pingcap:master Jul 8, 2018
@tiancaiamao tiancaiamao deleted the max-execution-time branch July 8, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/parser status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants