Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix drop user bug (#6624) #7014

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

zhexuany
Copy link
Contributor

@zhexuany zhexuany commented Jul 9, 2018

Thank you for working on TiDB! Please read TiDB's CONTRIBUTING document BEFORE filing this PR.

What have you changed? (mandatory)

This is a cherry-pick pr. Refer to #6624

What are the type of the changes (mandatory)?

cherry-pick

@zhexuany
Copy link
Contributor Author

zhexuany commented Jul 9, 2018

This addresses issue #7007. @tiancaiamao @coocood please review this cherry-pick if you guys have time. ;)

@coocood
Copy link
Member

coocood commented Jul 9, 2018

LGTM

@coocood coocood added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 9, 2018
@tiancaiamao tiancaiamao changed the title [cherry-pick] executor: fix drop user bug (#6624) executor: fix drop user bug (#6624) Jul 9, 2018
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 9, 2018
@zhexuany
Copy link
Contributor Author

zhexuany commented Jul 9, 2018

Thanks for quick response @coocood @tiancaiamao ;)

@zhexuany
Copy link
Contributor Author

zhexuany commented Jul 9, 2018

@shenli friendly ping. This cherry-pick was already approved.

@shenli shenli merged commit cef80ce into pingcap:release-2.0 Jul 9, 2018
@zhexuany zhexuany deleted the cherry_pick_pr_6624 branch October 22, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants