store/tikv: handle the error of "mismatch cluster id" #7053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Jul 13, 2018
store/tikv/backoff.go
Outdated
| @@ -233,6 +234,9 @@ func (b *Backoffer) Backoff(typ backoffType, err error) error { | |||
| } | |||
| } | |||
| log.Warn(errMsg) | |||
| if strings.Contains(errMsg, ErrMismatchClusterID.Error()) { | |||
There was a problem hiding this comment.
Can we define a string constant for "mismatch cluster id"?
There was a problem hiding this comment.
Is it better to check and handle this in the pd-client? @disksing What do you think about it?
There was a problem hiding this comment.
I think we can check it at the beginning of this function.
coocood
reviewed
Jul 16, 2018
store/tikv/error.go
Outdated
| @@ -22,6 +22,8 @@ import ( | |||
| var ( | |||
| // ErrBodyMissing response body is missing error | |||
| ErrBodyMissing = errors.New("response body is missing") | |||
| // ErrMismatchClusterID returns the error that the cluster ID of the PD client does not match the PD. | |||
| ErrMismatchClusterID = errors.New("mismatch cluster id") | |||
There was a problem hiding this comment.
We don't need to define an error if we never throw it.
I think just make the string constant and check the string will do.
|
LGTM |
ciscoxll
approved these changes
Jul 16, 2018
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
We will exit the current TiDB when we encounter the error of "mismatch cluster id, need 6577643568868929567 but got 6577623361857143480".
The TiDB will meet the error of “mismatch cluster id” when the cluster ID of the TiDB‘s PD client does not match the PD.
What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
In local
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No
Does this PR need to be added to the release notes? (mandatory)