executor: remove childrenResult from baseExecutor #7076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
zz-jason
reviewed
Jul 17, 2018
executor/aggregate.go
Outdated
| @@ -795,6 +801,15 @@ func (e *StreamAggExec) Open(ctx context.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // Close implements the Executor Close interface. | |||
| func (e *StreamAggExec) Close() error { | |||
| if err := e.baseExecutor.Close(); err != nil { | |||
There was a problem hiding this comment.
We could firstly release the resources handled by itself, then release the resources handled by its children.
XuHuaiyu
reviewed
Jul 17, 2018
| @@ -216,6 +225,9 @@ func (e *ProjectionExec) prepare(ctx context.Context) { | |||
|
|
|||
| // Close implements the Executor Close interface. | |||
| func (e *ProjectionExec) Close() error { | |||
| if e.isUnparallelExec() { | |||
There was a problem hiding this comment.
it paired for Open. It seems that alloc/dealloc child result chunk is required only when isUnparallel==true
|
/run-integration-common-test |
|
Is there a related issue about this PR? |
|
/run-integration-common-test |
|
LGTM |
remove childrenResult from baseExecutor and push down them to real implements if they real need children chunk. cut off useless childrenResult and childResult slice alloc.
XuHuaiyu
reviewed
Jul 18, 2018
executor/aggregate.go
Outdated
| // Close implements the Executor Close interface. | ||
| func (e *StreamAggExec) Close() error { | ||
| e.childResult = nil | ||
| if err := e.baseExecutor.Close(); err != nil { |
There was a problem hiding this comment.
return errors.Trace(e.baseExecutor.Close()) // I prefer this.or
err := e.baseExecutor.Close()
return errors.Trace(err)
winoros
reviewed
Jul 18, 2018
executor/executor.go
Outdated
| // Close implements the Executor Close interface. | ||
| func (e *LimitExec) Close() error { | ||
| e.childResult = nil | ||
| if err := errors.Trace(e.baseExecutor.Close()); err != nil { |
There was a problem hiding this comment.
You could just return it. It's ok not to have this if branch.
There was a problem hiding this comment.
This is what I mean in the previous comments.😂
executor/executor.go
Outdated
| // Close implements the Executor Close interface. | ||
| func (e *ExistsExec) Close() error { | ||
| e.childResult = nil | ||
| if err := errors.Trace(e.baseExecutor.Close()); err != nil { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
This is 1 of 3 PRs of "reduce chunk capacity". issue ref #7077
In this PR, we remove
childrenResultfrombaseExecutorand push down them to real implementsonly create result chunk for children only when it's really needed, and try create single chunk if no needed to use more than one.
What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
This change is