Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix big_unsigned_int union decimal sign bug #7202

Merged
merged 5 commits into from
Jul 31, 2018
Merged

executor: fix big_unsigned_int union decimal sign bug #7202

merged 5 commits into from
Jul 31, 2018

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Jul 31, 2018

What have you changed? (mandatory)

fixes #7200 and this is a bug introduced by #7112

  • use decimal special logic when resultType is decimal instead of previous one type.
  • add test case

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

  • unit tests
  • manual tests?

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Does this PR need to be added to the release notes? (mandatory)

no

Refer to a related PR or issue link (optional)

#7200


This change is Reviewable

use decimal logic when resultType is decimal instead of previous one type.
@lysu
Copy link
Contributor Author

lysu commented Jul 31, 2018

/run-all-tests

@lysu lysu added the type/bugfix This PR fixes a bug. label Jul 31, 2018
@lysu
Copy link
Contributor Author

lysu commented Jul 31, 2018

PTAL @XuHuaiyu thx~

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor Author

lysu commented Jul 31, 2018

/run-integration-ddl-test
/run-unit-test

@lysu
Copy link
Contributor Author

lysu commented Jul 31, 2018

/run-all-tests

@lysu
Copy link
Contributor Author

lysu commented Jul 31, 2018

/run-common-test
/run-integration-common-test

@XuHuaiyu
Copy link
Contributor

/run-common-test
/run-integration-common-test

@zz-jason
Copy link
Member

/run-all-tests

@lysu lysu merged commit 8739d80 into pingcap:master Jul 31, 2018
@lysu lysu deleted the dev/fix-unsign-union-decimal branch July 31, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select big_unsigned_int union decimal differ from mysql
3 participants