Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: fix a bug when eliminating projection #7257

Merged
merged 4 commits into from
Aug 2, 2018

Conversation

winoros
Copy link
Member

@winoros winoros commented Aug 2, 2018

What have you changed? (mandatory)

For update/insert/delete, there'll be ResolveIndices after Projection Elimination. So we should use the projection's columns instead of its child's.

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

newly added test.

@winoros winoros added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Aug 2, 2018
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Aug 2, 2018

/run-all-tests

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 2, 2018
@XuHuaiyu XuHuaiyu merged commit 5d96d56 into pingcap:master Aug 2, 2018
@winoros winoros deleted the uniqueid-projection branch August 8, 2018 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants