Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: refactor joinResultGenerator to handle the unmatched outer records (#7288) #7315

Merged
merged 2 commits into from
Aug 8, 2018

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Aug 8, 2018

What have you changed? (mandatory)

cherrypick #7288 to release-2.0

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

  • existing tests
  • newly added tests

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Does this PR need to be added to the release notes? (mandatory)

release note:
Fix a bug that the `Outer Join` may output the same unmatched outer records multiply times under certain special conditions.

@zz-jason zz-jason added type/bugfix This PR fixes a bug. type/2.0 cherry-pick sig/execution SIG execution labels Aug 8, 2018
@zz-jason
Copy link
Member Author

zz-jason commented Aug 8, 2018

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

@zz-jason
Copy link
Member Author

zz-jason commented Aug 8, 2018

@coocood @winoros @XuHuaiyu PTAL

@zz-jason zz-jason added status/all tests passed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 8, 2018
Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason merged commit 343ed54 into pingcap:release-2.0 Aug 8, 2018
@zz-jason zz-jason deleted the cherrypick/7288 branch August 8, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants