Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: support for flush status #7369

Merged
merged 5 commits into from
Aug 13, 2018
Merged

parser: support for flush status #7369

merged 5 commits into from
Aug 13, 2018

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Aug 13, 2018 •
edited by shenli
Loading

What problem does this PR solve?

Fix #7352 to make some JDBC test cases happy.

What is changed and how it works?

Support flush status syntax in parser. The implementation is a dummy one.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects
no

Related changes

@imtbkcat imtbkcat requested a review from jackysp August 13, 2018 05:54
@imtbkcat imtbkcat requested a review from coocood August 13, 2018 06:06
jackysp
jackysp reviewed Aug 13, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat
Copy link
Author

/run-all-tests

shenli
shenli approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli shenli added status/LGT2 Indicates that a PR has LGTM 2. and removed component/mysql-protocol labels Aug 13, 2018
@imtbkcat
Copy link
Author

/run-all-tests

@tiancaiamao tiancaiamao changed the title parser: Support for flush status parser: support for flush status Aug 13, 2018
@imtbkcat imtbkcat merged commit 87b16fc into pingcap:master Aug 13, 2018
@imtbkcat imtbkcat deleted the fix7352 branch August 13, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@shenli shenli shenli approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
component/parser status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imtbkcat @shenli @jackysp