infoschema: use the unified infoschema in "select ... information_schema.tables" #7459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
It's better to add a case according to #7421 , though it may be hard. |
|
LGTM |
zimulala
added
status/LGT1
coocood
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #7421.
In the same executor, the line uses the latest infoschema to get
dbs, but we use the transaction's infoschema to gettableon another line .The latest and a transaction's infoschema may be different when we do a lot of DDL.
What is changed and how it works?
Use the unified infoschema. In the same executor, we use the transaction's infoschema.
Check List
Tests
Like Reading from information_schema.table fails while DDL is being performed #7421
Side effects
This problem will appear after this #7037.