Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: add basictracer go #7532

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Conversation

zhexuany
Copy link
Contributor

@zhexuany zhexuany commented Aug 29, 2018

What problem does this PR solve?

This PR adds basictracer-go back.

What is changed and how it works?

changes are imported by running

dep ensure -add github.com/opentracing/basictracer-go
./hack/clean-vendor.sh

Check List

Tests

  • No code

Code changes
It only has code changes in vendor

Side effects

  • No side effects

Related changes

@zhexuany zhexuany mentioned this pull request Aug 29, 2018
3 tasks
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhexuany
Copy link
Contributor Author

#7513 removed basicatracer from vendor. We have to add it back.

@tiancaiamao
Copy link
Contributor

/run-all-tests

@coocood
Copy link
Member

coocood commented Aug 29, 2018

LGTM

@tiancaiamao tiancaiamao merged commit eec6899 into pingcap:master Aug 29, 2018
@zhexuany zhexuany deleted the add_basictracer_go branch August 29, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants