tidb-server: close Domain and Storage before HTTP listener #7558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If the tidb-server failed to quit, we need to know why.
But HTTP listener is closed before domain and storage, we can get the goroutine stack info.
It can be helpful to solve #7545
What is changed and how it works?
add
SetCleanupFunc
method toServer
, call this function inClose
before HTTP listener is closed.Check List
Tests
Sleep(time.Munite)
incleanup
.http://localhost:10080/debug/pprof
, we can see the page.Code changes