expression: Fix some datetime related cases that is inconsistent with MySQL #7636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pr fixes some
datetime
related cases in TiDB that is inconsistent with MySQL.NO_ZERO_DATE
is not taken into consideration in some builtin-time functions(month
,dayofmonth
,year
,monthname
). In MySQL, ifNO_ZERO_DATE
is not set, no error or warning should happen on zero datetime such as0000-00-00 00:00:00
.For example, in MySQL:
While in TiDB:
float
values are not correctly cast intodatetime
.For example, in MySQL:
While in TiDB:
What is changed and how it works?
Changed the way some builtin_time functions deal with
ZERO
datetimeCheck List
Tests
Unit tests && integration tests