Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: prune columns for LogicalTableDual #7725

Merged
merged 4 commits into from
Sep 17, 2018
Merged

plan: prune columns for LogicalTableDual #7725

merged 4 commits into from
Sep 17, 2018

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Fix #7723

What is changed and how it works?

Add PruneColumns method for LogicalTableDual.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has interface methods change

@eurekaka eurekaka added the sig/planner SIG: Planner label Sep 17, 2018
XuHuaiyu
XuHuaiyu reviewed Sep 17, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka
Copy link
Contributor Author

/run-all-tests

zz-jason
zz-jason approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. labels Sep 17, 2018
@eurekaka eurekaka merged commit 44e0578 into pingcap:master Sep 17, 2018
@eurekaka eurekaka deleted the prune_col_dual branch September 17, 2018 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eurekaka @zz-jason @XuHuaiyu