plan: fix predicate push down for UnionScan #7726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests tikv=release-2.0 tidb-test=release-2.0 pd=release-2.0 |
|
LGTM |
|
@coocood maybe need try this test PR https://github.com/pingcap/tidb-test/pull/624 |
|
/run-common-test tidb-test=pr/624 tikv=release-2.0 pd=release-2.0 |
|
/run-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
|
/run-all-tests tidb-test=pr/624 tikv=release-2.0 pd=release-2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry-pick #7695
What is changed and how it works?
The predicate push down for UnionScan plan returns retained predicates instead of nil.
If we return nil predicates, the parent Selection will be removed, but conditions in UnionScan is only used to evaluate dirty table added rows, the conditions that cannot be pushed down to coprocessor will be lost.
Check List
Tests